dongjoon-hyun commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r854355561
##########
c++/src/sargs/SargsApplier.hh:
##########
@@ -60,10 +60,11 @@ namespace orc {
const std::map<uint32_t, BloomFilterIndex>&
bloomFilters);
/**
- * Return a vector of bool for each row group for their selection
- * in the last evaluation
+ * Return a vector of the next skipped row for each RowGroup. Each value
is the row id
+ * in stripe. 0 means the current RowGroup is entirely skipped.
+ * Only valid after invoking pickRowGroups().
*/
- const std::vector<bool>& getRowGroups() const { return mRowGroups; }
Review Comment:
I'm fine with the AS-IS PR if you folks are sure. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
