[Dev] review stalemate - what to do next?

[Mike Taylor]

Earlier today Heikki and I reached the point where we could not find common ground on the result of a review I requested from him about some changes to the Makefiles. I think that one of the review points he raised is not a concern (a "style" issue to be exact) where as he thinks the code is wrong because of duplication.

If the reviewer and the owner disagree, which of the following apply:

        1. Owner's opinion prevails
        2. Reviewer's opinion prevails

        4. <insert alternative solution here>

thanks,

---
Bear

Build and Release Engineer
Open Source Applications Foundation (OSAF)
[EMAIL PROTECTED]
http://www.osafoundation.org

[EMAIL PROTECTED]
http://code-bear.com

PGP Fingerprint = 9996 719F 973D B11B E111  D770 9331 E822 40B3 CD29

The exact code involved is not the question I'm raising right now, but rather this is something we haven't considered in our review process - what happens when the owner of the patch/code and the reviewer of the patch/code just cannot agree? After talking about this with Heikki, he asked that I submit it as a discussion and vote to the dev list. 3. It's put to a vote before an impartial body - most of the time that body will be the dev list

PGP.sig
Description: This is a digitally signed message part

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "Dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/dev