|
I've lived in worlds 1, 2 and 3, and in my experience 1 has worked best. The guy whose working on the code needs to feel that he has ownership, which is important for his motivation. In the long run good and bad ideas often sort themselves out through use and time, so even if the owner chooses the wrong choice, he'll often change his mind if experience bears out a bad decision, which turn out to be an important learning experience. I've almost never seen the owner abuse the privilege of overruling a reviews opinion, that actually hurt the project. John Mike Taylor wrote: Earlier today Heikki and I reached the point where we could not find common ground on the result of a review I requested from him about some changes to the Makefiles. I think that one of the review points he raised is not a concern (a "style" issue to be exact) where as he thinks the code is wrong because of duplication. |
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ Open Source Applications Foundation "Dev" mailing list http://lists.osafoundation.org/mailman/listinfo/dev
