eldk commented on a change in pull request #1703: Removes deprecated
mod_access_compat directives
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r166147780
##########
File path: install/common/pagespeed.conf.template
##########
@@ -321,15 +321,19 @@
# and change server state, such as statistics, caches, and
# messages. This might be appropriate in an experimental setup.
<Location /pagespeed_admin>
- Order allow,deny
- Allow from localhost
- Allow from 127.0.0.1
+ Require all granted
+ Require local
Review comment:
>can you put these under ifdef so this still works on 2.2? Or will it work
on 2.2 as is?
I will put ifdef, as it can't work with apache 2.2.
Apache 2.2 directives may be kept in 2.4, but may have "weird" unexpected
behavior, so ifdef is the best solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
