eldk commented on a change in pull request #1703: Removes deprecated 
mod_access_compat directives
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r166161813
 
 

 ##########
 File path: install/common/pagespeed.conf.template
 ##########
 @@ -321,15 +321,19 @@
     # and change server state, such as statistics, caches, and
     # messages.  This might be appropriate in an experimental setup.
     <Location /pagespeed_admin>
-        Order allow,deny
-        Allow from localhost
-        Allow from 127.0.0.1
+        Require all granted
+        Require local
 
 Review comment:
   ```
   # Attempt to load mod_version if it wasn't loaded or compiled in (eg on 
Debian)
   <IfModule !mod_version.c>
   LoadModule version_module /usr/lib/httpd/modules/mod_version.so
   </IfModule>
   <Location /pagespeed_admin>
           <IfVersion <2.4>
               Order allow,deny
               Allow from localhost
               Allow from 127.0.0.1
               <IfVersion>
           <IfVersion >= 2.4>
               Require all granted
               Require local
               #Require ip, host or forward-dns  - see 
https://httpd.apache.org/docs/current/fr/mod/mod_authz_host.html
               </IfVersion>
           SetHandler pagespeed_admin
       </Location>
    <Location /pagespeed_global_admin>
           <IfVersion <2.4>
               Order allow,deny
               Allow from localhost
               Allow from 127.0.0.1
               <IfVersion>
           <IfVersion >= 2.4>
               Require all granted
               Require local
             #Require ip, host or forward-dns
               </IfVersion>
             SetHandler pagespeed_global_admin
       </Location>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to