jmarantz commented on issue #1899: data-srcset in img and amp-img URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-503557496 Lofesa, are you able to run the integration tests locally? WDYT of adding a unit-test as well? I noticed also that you have a test for "data-srcset" but I don't see a config update to look for that attribute (e.g. with UrlValuedAttribute) nor do I see that attribute as an html standard on a web search. It does look like it's used as an ad-hoc placeholder in some JS libraries, but I don't know if we should hard-code for that. It probably doesn't do any harm, but I just wanted to bring that up. Thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
