jmarantz commented on issue #1899: data-srcset in img and amp-img URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-503586057 RE "I ran it in production" -- awesome! I believe it works. However I still hope we can maintain good software engineering discipline and have unit and integration tests that we validate are working as well, so that we ensure it stays working across future changes. I think it's possible our unit-tests are run in CI but maybe not our integration tests,. @oschaaf can you remind me? It will also benefit you a lot to be able to run them locally for iteration. RE "data-srcset" is defacto standard; I'm OK with that, especially as it's unlikely for it to be present in html for some other purpose. @oschaaf WDYT? RE this whole flow being obsolete in favor of browsers directly supporting lazy...what do you recommend with respect to this PR?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
