Lofesa commented on issue #1899: data-srcset in img and amp-img URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-503594170 Hi @jmarantz Well.... I'm not a developer but I learn, more or less. I do not know if I would like to develop a unit test but everything is to start. Where to start? RE:but maybe not our integration tests I think yes as far as these messages are in the log: TEST: rewrite_images_datasrcset can rewrite data-srcset itself RE:what do you recommend with respect to this PR? I think this PR should be merged because until the new functionality is present in all, or most, browsers will spend a lot of time and while people will continue to use data-srcset. But preemptively you have to go thinking about what happens with the filter lazyload_images and their implications. P.S: Sorry for my bad english.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
