Lofesa commented on issue #1899: data-srcset in img and amp-img
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-503659934
 
 
   > @Lofesa this LGTM, but I think we can condense/simplify the code a bit. 
That would be great to include before merging this. Let's sync up on Slack to 
get that sorted.
   
   Well.... I make this doble if cause at first they are out of the if loop 
that iterates trougth the attributes of a element and need to ask for both 
(srcset and data-srcset). Now that are in to the loop can be simplified, sure
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to