patrickhulce commented on issue #2068:
URL: 
https://github.com/apache/incubator-pagespeed-mod/issues/2068#issuecomment-846022934


   > Is not the same with inlined images?
   
   It is not. Encoded images formats like JPEG/WebP/PNG need to be decoded on a 
separate background thread, so layouts happen in between. In practice it 
appears that the layout is not affected on fast machines for JPEG on Chromium 
(perhaps because Chromium at least waits for the header with dimensions to be 
decoded? I'm not sure). If you have other knowledge that this behavior is 
actually guaranteed in all browsers, happy to open new discussion over there 
about excluding all non-network images.
   
   > Another way to set image size is with css, Is this way acceptable for LH?
   
   Sure, any method of fixed sizing will work for Lighthouse, but it appears 
that the OP was already setting them via attributes and this mod removed them. 
Seems reasonable to at least keep attributes the developer intended, even if 
they aren't strictly necessary for this specific image on Chrome, no?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to