-1 Do not approve.

I verified the source checksum/signature, Git tag and commit, ASF license
headers, LICENSE/NOTICE, dependency licenses, Java artifacts, and Python
wheels. All of those checks passed.

However, the workspace declares rust-version = "1.86", while the locked
dependencies cannot be built with Rust 1.86:

- darling 0.23.0 requires Rust 1.88
- time 0.3.53 requires Rust 1.88
- roaring 0.11.4 requires Rust 1.90

`cargo +1.86.0 test --workspace --locked` fails before compilation.
The complete workspace test suite passes with Rust 1.90.

Please either update the declared MSRV to 1.90 or pin dependencies compatible
with Rust 1.86 and create a new release candidate.

Best,
Junhao

> 2026年7月13日 15:36,yu zelin <[email protected]> 写道:
> 
> +1 (binding)
> 
> I checked:
> - Downloaded source tarball, verified sha512 and GPG signature.
> - Verified git tag v0.1.0-rc2 points to commit
> e2c57ddf5c3441eb991b3b268b2ce1d9e01100fb.
> - Checked LICENSE/NOTICE and ASF license headers.
> - Built and tested from source:
>  - cargo test --workspace passed.
>  - Java JNI round-trip tests passed.
>  - Python FFI tests passed.
> - Verified Java staging artifacts checksums and signatures.
> - Checked TestPyPI wheels and installed the macOS arm64 wheel for a smoke 
> test.
> 
> Best Regards,
> Zelin Yu
> 
> 
> On Mon, Jul 13, 2026 at 10:52 AM Jingsong Li <[email protected]> wrote:
> 
>> +1 binding
>> 
>> I verified the source SHA-512 and OpenPGP signature, confirmed the
>> tag resolves to e2c57ddf5c3441eb991b3b268b2ce1d9e01100fb, and checked
>> that the source archive matches the tag.
>> 
>> LICENSE, NOTICE, dependency licensing, and ASF license headers pass.
>> The source builds successfully, and the Rust, Java/JNI, and Python
>> tests pass. I also verified the staged Maven artifacts and TestPyPI
>> wheels.
>> 
>> No blocking issues found.
>> 
>> Best,
>> Jingsong
>> 
>> On Thu, Jul 9, 2026 at 5:46 PM Jimmy Tian <[email protected]>
>> wrote:
>>> 
>>> Hi everyone,
>>> 
>>> Please review and vote on release candidate #2 for Apache Paimon Full
>> Text
>>> 0.1.0.
>>> 
>>> This RC fixes the missing ASF license headers reported in RC1.
>>> 
>>> [ ] +1 Approve the release
>>> [ ] +0 No opinion
>>> [ ] -1 Do not approve (please provide specific comments)
>>> 
>>> The release candidate is available at:
>>> 
>> https://dist.apache.org/repos/dist/dev/paimon/paimon-full-text-0.1.0-rc2/
>>> 
>>> Git tag:
>>> https://github.com/apache/paimon-full-text/releases/tag/v0.1.0-rc2
>>> 
>>> Git commit:
>>> e2c57ddf5c3441eb991b3b268b2ce1d9e01100fb
>>> 
>>> KEYS for signature verification:
>>> https://downloads.apache.org/paimon/KEYS
>>> 
>>> Java artifacts (Nexus staging):
>>> https://repository.apache.org/content/repositories/orgapachepaimon-1176/
>>> 
>>> Python wheels (TestPyPI):
>>> https://test.pypi.org/project/paimon-ftindex/0.1.0rc2/
>>> 
>>> The vote will be open for at least 72 hours.
>>> 
>>> Thanks,
>>> Jianguo Tian
>> 

Reply via email to