I'm not sure, but I don't want this to block the release.
It looks like the expected way to filter columns is through the read
support properties, not by supplying a ThriftProjectionFilter. We also
don't expect users to be supplying their own ReadSupport for Thrift and
are okay considering this not public and breaking any that exist.
If we agree on those two statements, then I don't think this should
block the release.
rb
On 07/14/2015 11:12 AM, Alex Levenson wrote:
FieldProjectionFilter and ThriftSchemaConverter are internals to the thrift
read support, they should be have been made private from the start.
They shouldn't actually be used directly by users of either of the thrift
read supports. Is that good enough, or does the fact that they have been
exposed already make this a blocker?
On Mon, Jul 13, 2015 at 6:53 PM, Ryan Blue <[email protected]> wrote:
Everyone, I have an issue that might be a release blocker: there appear to
be incompatible changes in the org.apache.parquet.thrift.projection API.
I'm not 100% sure that this is public, but it appears to be.
FieldProjectionFilter changed from a class to an interface, which is a
breaking change. This is exposed in the ThriftSchemaConverter constructor,
which I believe makes it public. It is also used by the Scrooge read
support.
Perhaps we need to deprecate that constructor and find some way to fix the
Scrooge support, but I would like to make sure this isn't an incompatible
change before releasing this.
Can anyone comment on this?
rb
On 07/13/2015 11:10 AM, Chris Aniszczyk wrote:
+1, notices check out, builds and tests pass
On Mon, Jul 13, 2015 at 9:29 AM, Jake Farrell <[email protected]>
wrote:
+1
Ran through checklist and tests and all looks good
-Jake
On Sat, Jul 11, 2015 at 8:36 PM, Ryan Blue <[email protected]> wrote:
Hi everyone,
I propose the following RC to be released as official Apache Parquet
1.8.0
release.
The commit id is 0fda28af84b9746396014ad6a415b90592a98b3b
* This corresponds to the tag: apache-parquet-1.8.0
* https://github.com/apache/parquet-mr/tree/0fda28af
(Github sync has been down lately, might not work.)
*
https://git-wip-us.apache.org/repos/asf/projects/repo?p=parquet-mr.git&a=commit&h=0fda28af84b9746396014ad6a415b90592a98b3b
The release tarball, signature, and checksums are here:
*
https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.8.0-rc1/
You can find the KEYS file here:
* https://dist.apache.org/repos/dist/dev/parquet/KEYS
Binary artifacts are staged in Nexus here:
*
https://repository.apache.org/content/groups/staging/org/apache/parquet/
This release includes bug fixes for 2 major problems:
* PARQUET-251: Incorrect min/max values in binary stats
* PARQUET-246: Cannot read delta byte array columns (format v2 only)
Please download, verify, and test.
Please vote by around 1800 PDT on Tuesday.
[ ] +1 Release this as Apache Parquet 1.8.0
[ ] +0
[ ] -1 Do not release this because...
--
Ryan Blue
--
Ryan Blue
Software Engineer
Cloudera, Inc.
--
Ryan Blue
Software Engineer
Cloudera, Inc.
