[ 
https://issues.apache.org/jira/browse/PARQUET-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092596#comment-15092596
 ] 

Kalon Mills commented on PARQUET-267:
-------------------------------------

Do you mean something more specific then the readme in the pull request?  I 
think the readme is pretty clear about how to guide cmake to find dependencies. 
 It should work quite well with pointing at any toolchain.  I'm not really sure 
what to add that wouldn't be super specific.

> Detach thirdparty code from build configuration.
> ------------------------------------------------
>
>                 Key: PARQUET-267
>                 URL: https://issues.apache.org/jira/browse/PARQUET-267
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Kalon Mills
>            Priority: Minor
>
> The existing repo has source code for third party dependencies checked into 
> the repo.  The build system expects those dependencies in a certain place.  
> This enforces that the built library conform to those exact dependencies 
> without customization.
> Managing third party dependencies is better handled through a build 
> environment.  It allows the library builder more flexibility over dependency 
> versions and locations.  It also cleans up the repo from this third party 
> code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to