[ 
https://issues.apache.org/jira/browse/PARQUET-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154551#comment-15154551
 ] 

Deepak Majeti commented on PARQUET-532:
---------------------------------------

The fix for this will be included in the patch for PARQUET-526 that [~asandryh] 
is working on.

> Null values detection needs to be fixed and tested
> --------------------------------------------------
>
>                 Key: PARQUET-532
>                 URL: https://issues.apache.org/jira/browse/PARQUET-532
>             Project: Parquet
>          Issue Type: Bug
>            Reporter: Deepak Majeti
>            Assignee: Aliaksei Sandryhaila
>
> The scanner.h code for detecting NULLs has to be fixed and validated with 
> test cases.
> The below code seems to be wrong.
> {code}
> // Returns true if there is a next value
> bool NextValue(T* val, bool* is_null) {
> ....
> *is_null = def_level < rep_level;
>     if (*is_null) {
>       return true;
>     }
> ....
> }
> {code}
> according to the spec, a NULL value has a definition level, if any, less than 
> the maximum definition level. If the value is NULL, false must be returned 
> here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to