[
https://issues.apache.org/jira/browse/PARQUET-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155382#comment-15155382
]
Wes McKinney commented on PARQUET-533:
--------------------------------------
See patch https://github.com/apache/parquet-cpp/pull/59
Can be merged after PARQUET-457
> Simplify RandomAccessSource API to combine Seek/Read
> -----------------------------------------------------
>
> Key: PARQUET-533
> URL: https://issues.apache.org/jira/browse/PARQUET-533
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Minor
>
> In situations where memory-mapping is available, copying bytes into a
> newly-allocated memory buffer may be unnecessary.
> I propose to generally simplify the interface to random-access capable data
> sources to instead return a {{Buffer}} object (that I'll define) whose
> subclasses can be responsible for RAII memory-allocation/deallocation if it
> is necessary. This way, users of {{RandomAccessSource}} need not necessarily
> be responsible for memory allocation and object lifetime management.
> Not an urgent matter but will get a patch together sometime in the next
> several weeks (most likely at the same time as adding a memory-mapped file
> input source).
> As an aside, it would be useful to have this same kind of abstraction
> available in the context of compressed data pages (note the decompression
> buffer member variable in {{ColumnReader}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
