[ 
https://issues.apache.org/jira/browse/PARQUET-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261911#comment-16261911
 ] 

ASF GitHub Bot commented on PARQUET-970:
----------------------------------------

advancedxy commented on issue #419: PARQUET-970: Add Lz4 and Zstd compression 
codec
URL: https://github.com/apache/parquet-cpp/pull/419#issuecomment-346231165
 
 
   Yeah, I know the update to `parquet.thrift` should be sufficient for this 
change. But do we need to sync with upstream: 
[parquet-format/parquet.thrift](https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift)?
 (I checked that file, and seems there are other changes made into 
parquet.thrift)
   
   
   
   >For libztd.a, you will need at least add zstd to 
https://github.com/apache/parquet-cpp/blob/master/ci/travis_script_toolchain.sh#L43
 so that it is installed from conda-forge
   
   I don't know arrow's building procedure very well, but from my 
understanding, shouldn't zstd be part of dependency of arrow, and downloaded 
automatically?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add ZstdCompressor for parquet-cpp compressor interface
> -------------------------------------------------------
>
>                 Key: PARQUET-970
>                 URL: https://issues.apache.org/jira/browse/PARQUET-970
>             Project: Parquet
>          Issue Type: New Feature
>          Components: parquet-cpp
>            Reporter: Xianjin YE
>            Assignee: Xianjin YE
>
> https://github.com/facebook/zstd looks quite promising, I'd like to add a 
> compressor in parquet-cpp.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to