[ https://issues.apache.org/jira/browse/PARQUET-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288631#comment-16288631 ]
ASF GitHub Bot commented on PARQUET-1177: ----------------------------------------- wesm commented on issue #425: PARQUET-1177: Add PARQUET_BUILD_WARNING_LEVEL option and more rigorous Clang warnings URL: https://github.com/apache/parquet-cpp/pull/425#issuecomment-351264472 Think I've got the compiler warnings fixed now, we'll see about MSVC ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] Add more extensive compiler warnings when using Clang > ----------------------------------------------------------- > > Key: PARQUET-1177 > URL: https://issues.apache.org/jira/browse/PARQUET-1177 > Project: Parquet > Issue Type: Improvement > Components: parquet-cpp > Reporter: Wes McKinney > Assignee: Wes McKinney > Fix For: cpp-1.4.0 > > > We should add a "build warning level" flag like Apache Arrow, see > https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L73 > This will help us keep things clean -- This message was sent by Atlassian JIRA (v6.4.14#64029)