[
https://issues.apache.org/jira/browse/PARQUET-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397313#comment-16397313
]
ASF GitHub Bot commented on PARQUET-968:
----------------------------------------
qinghui-xu commented on a change in pull request #411: PARQUET-968 Add
Hive/Presto support in ProtoParquet
URL: https://github.com/apache/parquet-mr/pull/411#discussion_r174216544
##########
File path:
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoMessageConverter.java
##########
@@ -129,10 +131,14 @@ public void add(Object value) {
};
}
- return newScalarConverter(parent, parentBuilder, fieldDescriptor,
parquetType);
+ OriginalType originalType = parquetType.getOriginalType() == null ?
OriginalType.UTF8 : parquetType.getOriginalType();
Review comment:
I guess for the data generated in previous version of parquet-protobuf, it
is not having the "OriginalType" annotation for repeated fields, thus this
conditional test to be backward compatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Hive/Presto support in ProtoParquet
> ---------------------------------------
>
> Key: PARQUET-968
> URL: https://issues.apache.org/jira/browse/PARQUET-968
> Project: Parquet
> Issue Type: Task
> Reporter: Constantin Muraru
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
