[jira] [Commented] (PARQUET-1315) [C++] ColumnChunkMetaData.has_dictionary_page() should return bool, not int64_t

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/PARQUET-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496374#comment-16496374
 ] 

ASF GitHub Bot commented on PARQUET-1315:
-----------------------------------------

xhochy closed pull request #469: PARQUET-1315: 
ColumnChunkMetaData.has_dictionary_page() should return…
URL: https://github.com/apache/parquet-cpp/pull/469
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/parquet/metadata.cc b/src/parquet/metadata.cc
index fc420b01..ee91b393 100644
--- a/src/parquet/metadata.cc
+++ b/src/parquet/metadata.cc
@@ -141,7 +141,7 @@ class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
 
   const std::vector<Encoding::type>& encodings() const { return encodings_; }
 
-  inline int64_t has_dictionary_page() const {
+  inline bool has_dictionary_page() const {
     return column_->meta_data.__isset.dictionary_page_offset;
   }
 
@@ -206,7 +206,7 @@ std::shared_ptr<RowGroupStatistics> 
ColumnChunkMetaData::statistics() const {
 
 bool ColumnChunkMetaData::is_stats_set() const { return impl_->is_stats_set(); 
}
 
-int64_t ColumnChunkMetaData::has_dictionary_page() const {
+bool ColumnChunkMetaData::has_dictionary_page() const {
   return impl_->has_dictionary_page();
 }
 
diff --git a/src/parquet/metadata.h b/src/parquet/metadata.h
index 3ba57ac0..84c14707 100644
--- a/src/parquet/metadata.h
+++ b/src/parquet/metadata.h
@@ -108,7 +108,7 @@ class PARQUET_EXPORT ColumnChunkMetaData {
   std::shared_ptr<RowGroupStatistics> statistics() const;
   Compression::type compression() const;
   const std::vector<Encoding::type>& encodings() const;
-  int64_t has_dictionary_page() const;
+  bool has_dictionary_page() const;
   int64_t dictionary_page_offset() const;
   int64_t data_page_offset() const;
   int64_t index_page_offset() const;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] ColumnChunkMetaData.has_dictionary_page() should return bool, not 
> int64_t
> -------------------------------------------------------------------------------
>
>                 Key: PARQUET-1315
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1315
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Antoine Pitrou
>            Assignee: Deepak Majeti
>            Priority: Major
>             Fix For: cpp-1.5.0
>
>
> It's semantically a boolean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)