Thanks Uwe, I'll update the script to make it easier next time. On Thu, Jan 31, 2019 at 1:45 PM Uwe L. Korn <uw...@xhochy.com> wrote:
> +1 (binding) > > Build and tested using Ryan's script on Ubuntu 16.04. > > The script helped me a bit as it included the necessary maven options. > Thanks! > > For future, it would be good to include one as we have in Arrow that also > checks the signature. We have that in the main tree and the script also > downloads the source tarball. Then the script is simply in git and not part > of the release. > > Uwe > > > On Thu, Jan 31, 2019, at 7:36 PM, Ryan Blue wrote: > > Uwe suggested that we include a validation script for release votes. It's > a little late to add one to this release, but here is one to make it > easier. Just run the attached script from the project root. > > The script checks for the correct versions of thrift and protobuf. If > found, those modules and modules that depend on them are built and tested. > Otherwise, it just tests the modules that don't require additional > installs. This builds the project and runs RAT checks, then runs tests and > prints a message at the end. > > rb > > > On Wed, Jan 30, 2019 at 10:11 PM Dongjoon Hyun <dongjoon.h...@gmail.com> > wrote: > > +1 for 1.10.1 RC0 (non-binding). > > I tested the src tar artifact on Ubuntu 16.04 and passed all UTs. > (Also, I saw the result of Ryan's Spark PR > https://github.com/apache/spark/pull/23704.) > > Thank you for the release. > > Cheers, > Dongjoon. > > On Wed, Jan 30, 2019 at 5:07 PM Dongjoon Hyun <dongjoon.h...@gmail.com> > wrote: > > Sure! I'll make a PR for that. > > Bests, > Dongjoon. > > On Wed, Jan 30, 2019 at 3:11 PM Ryan Blue <rb...@netflix.com> wrote: > > Looks like the README is out of date. I don't think we should fail this RC > based on the README. Can you open a pull request to update it. > > I think the correct version is protobuf 3.5.1 for the 1.10.x line. And we > should remove the current release from the README. > > On Wed, Jan 30, 2019 at 1:27 PM Dongjoon Hyun <dongjoon.h...@gmail.com> > wrote: > > Hi, All. > > For RC testing, I downloaded the src tar file and followed the README. I'm > wondering if the README is up-to-date and proper. > > In the master branch, `protoc` is handled by maven plugin. > > But, in RC, while `.travis.yml` installs `protobuf-3.5.1`, README guides > to install `protobuf-2.5.0` and eventually fails due to `TestProto3.proto`. > > main: > [mkdir] Created dir: > /Users/dongjoon/APACHE/RC-PARQUET/apache-parquet-1.10.1/parquet-protobuf/target/generated-test-sources > [mkdir] Created dir: > /Users/dongjoon/APACHE/RC-PARQUET/apache-parquet-1.10.1/parquet-protobuf/target/generated-test-sources/java > [exec] src/test/resources/TestProto3.proto:1:10: Unrecognized syntax > identifier "proto3". This parser only recognizes "proto2". > > > Also, README says `The current release is version 1.8.1` instead of > `1.10.1`. Is it worth to fix? > > Bests, > Dongjoon. > > > On Wed, Jan 30, 2019 at 10:45 AM Ryan Blue <rb...@netflix.com.invalid> > wrote: > > +1 (binding) > > Validated source signature, checksum. Ran unit tests. Tested Iceberg with > the candidate. > > For reference, here’s how to add test this candidate in a gradle project: > > repositories { > ... > maven { > url ' > https://repository.apache.org/content/repositories/orgapacheparquet-1022/' > } > } > > And in a maven project: > > <repositories> > ... > <repository> > <id>parquet-1.10.1</id> > <!-- This is a temporary repository, only needed for testing > before the Parquet release is final --> > <name>Parquet 1.10.1 RC0</name> > <url> > https://repository.apache.org/content/repositories/orgapacheparquet-1022/ > </url> > <releases> > <enabled>true</enabled> > </releases> > <snapshots> > <enabled>false</enabled> > </snapshots> > </repository> > </repositories> > > > On Tue, Jan 29, 2019 at 6:06 AM Nandor Kollar <nkol...@cloudera.com.invalid > > > wrote: > > > +1 (non-binding) > > > > Verified signature and checksum, ran unit tests, all passed. > > > > Cheers, > > Nandor > > > > On Tue, Jan 29, 2019 at 1:21 PM Gabor Szadovszky <ga...@apache.org> > wrote: > > > > > Hi Ryan, > > > > > > Checked the tarball: checksum/signature are correct. Content is correct > > > based on the release tag. Unit tests pass. > > > > > > +1 (non-binding) > > > > > > Cheers, > > > Gabor > > > > > > > > > On Mon, Jan 28, 2019 at 11:08 PM Ryan Blue <rb...@netflix.com.invalid> > > > wrote: > > > > > > > Hi everyone, > > > > > > > > I propose the following RC to be released as official Apache Parquet > > Java > > > > 1.10.1 release. > > > > > > > > The commit id is a89df8f9932b6ef6633d06069e50c9b7970bebd1 > > > > > > > > - This corresponds to the tag: apache-parquet-1.10.1 > > > > - https://github.com/apache/parquet-mr/commit/a89df8f > > > > - https://github.com/apache/parquet-mr/tree/apache-parquet-1.10.1 > > > > > > > > The release tarball, signature, and checksums are here: > > > > > > > > - > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.10.1-rc0/ > > > > > > > > You can find the KEYS file here: > > > > > > > > - https://dist.apache.org/repos/dist/dev/parquet/KEYS > > > > > > > > Binary artifacts are staged in Nexus here: > > > > > > > > - > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheparquet-1022/ > > > > > > > > This release is a patch release for Parquet 1.10.0. It includes the > > > > following bug fixes: > > > > > > > > - PARQUET-1309: Properties to disable stats and dictionary > filtering > > > are > > > > swapped > > > > - PARQUET-1510: Dictionary filter bug skips null for notEq with > > > > dictionary of one value > > > > > > > > Please download, verify, and test. > > > > > > > > Please vote in the next 72 hours: > > > > > > > > [ ] +1 Release this as Apache Parquet Java 1.10.1 > > > > [ ] +0 > > > > [ ] -1 Do not release this because… > > > > -- > > > > Ryan Blue > > > > Software Engineer > > > > Netflix > > > > > > > > > > > > -- > Ryan Blue > Software Engineer > Netflix > > > > -- > Ryan Blue > Software Engineer > Netflix > > > > -- > Ryan Blue > Software Engineer > Netflix > > Email had 1 attachment: > > - validate_parquet.sh > 2k (application/x-shellscript) > > > -- Ryan Blue Software Engineer Netflix
