[ 
https://issues.apache.org/jira/browse/PARQUET-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761048#comment-16761048
 ] 

Wes McKinney commented on PARQUET-1523:
---------------------------------------

OK. Do you want to try to remove the usages of "extern template class" while 
you are at it? 

> [C++] Vectorize comparator interface
> ------------------------------------
>
>                 Key: PARQUET-1523
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1523
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Deepak Majeti
>            Priority: Major
>             Fix For: cpp-1.6.0
>
>
> The {{parquet::Comparator}} interface yields scalar virtual calls on the 
> innermost loop. In addition to removing the usage of 
> {{PARQUET_TEMPLATE_EXPORT}} as with other recent patches, I propose to 
> refactor to a vector-based comparison to update the minimum and maximum 
> elements in a single virtual call
> cc [~mdeepak] [~xhochy]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to