[ 
https://issues.apache.org/jira/browse/PARQUET-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993618#comment-16993618
 ] 

Emmanuel Brard commented on PARQUET-1717:
-----------------------------------------

I did already https://github.com/apache/parquet-mr/pull/706
Not sure I properly followed the guideline tho :/

> parquet-thrift converts Thrift i16 to parquet INT32 instead of INT_16
> ---------------------------------------------------------------------
>
>                 Key: PARQUET-1717
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1717
>             Project: Parquet
>          Issue Type: Wish
>          Components: parquet-thrift
>    Affects Versions: 1.11.0
>            Reporter: Emmanuel Brard
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently when converting Thrift to Parquet, the ThriftSchemaConverter will 
> convert a i16 thrift data type as a INT32 Parquet data type even if the 
> logical type INT(16, false) would be more representative, especially for 
> downstream consumers of the parquet files.
> Using the logical data type requires a change in this method:
> {code:java}
>  @Override
>   public ConvertedField visit(I16Type i16Type, State state) {
>     return visitPrimitiveType(INT32, state);
>   }
> {code}
> from the ThriftSchemaConvertVisitor



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to