[
https://issues.apache.org/jira/browse/PARQUET-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015463#comment-17015463
]
ASF GitHub Bot commented on PARQUET-1767:
-----------------------------------------
brimzi commented on pull request #748: PARQUET-1767:
InternalParquetRecordWriter doesn't immediately limit current row group to
threshold
URL: https://github.com/apache/parquet-mr/pull/748
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> InternalParquetRecordWriter doesn't immediately limit current row group to
> threshold
> ------------------------------------------------------------------------------------
>
> Key: PARQUET-1767
> URL: https://issues.apache.org/jira/browse/PARQUET-1767
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Reporter: Brian Mwambazi
> Priority: Minor
> Labels: pull-request-available
>
> The MemoryManager adjust the row group size threshold of writers when the
> allocated memory pool fills up.
> *Problem*: However InternalParquetRecordWriter only re-adjusts the row group
> size on the next flush meaning they still use the old size.
> This opens up a possibility of getting an OOM error if all writers are
> started at relatively the same time and progress in tandem(I saw this when
> investigating failing jobs while writing to disk in Spark)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
