[ https://issues.apache.org/jira/browse/PARQUET-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031117#comment-17031117 ]
ASF GitHub Bot commented on PARQUET-1787: ----------------------------------------- garawalid commented on pull request #753: PARQUET-1787: Fix parsing expected distinct numbers URL: https://github.com/apache/parquet-mr/pull/753 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-XXX - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expected distinct numbers is not parsed correctly > ------------------------------------------------- > > Key: PARQUET-1787 > URL: https://issues.apache.org/jira/browse/PARQUET-1787 > Project: Parquet > Issue Type: Bug > Components: parquet-mr > Reporter: Walid Gara > Priority: Critical > Labels: pull-request-available > > In the bloom filter feature, when I pass the expected distinct numbers as > below, I got null values instead of 1000 and 200. > {code:java} > import org.apache.hadoop.conf.Configuration; > Configuration conf = new Configuration(); > conf.set("parquet.bloom.filter.column.names", "content,line"); > conf.set("parquet.bloom.filter.expected.ndv","1000,200"); > {code} > > The issue is coming from getting the system property of expected distinct > numbers through > [Long.getLong(expectedNDVs[i])|https://github.com/apache/parquet-mr/blob/a737141a571e3cb6cee2c252dc4406e26e6c1177/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java#L251]. > > It's possible to fix it by parsing the string with > Long.parseLong(expectedNDVs[i]). > -- This message was sent by Atlassian Jira (v8.3.4#803005)