[
https://issues.apache.org/jira/browse/PARQUET-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119449#comment-17119449
]
ASF GitHub Bot commented on PARQUET-1866:
-----------------------------------------
gszadovszky commented on a change in pull request #793:
URL: https://github.com/apache/parquet-mr/pull/793#discussion_r432376409
##########
File path: parquet-hadoop/README.md
##########
@@ -324,9 +324,20 @@ ParquetInputFormat to materialize records. It should be a
the descendant class o
**Property:** `parquet.read.schema`
**Description:** The read projection schema.
-
## Class: UnmaterializableRecordCounter
**Property:** `parquet.read.bad.record.threshold`
**Description:** The percentage of bad records to tolerate.
**Default value:** `0`
+
+## Class: ZstandardCodec
+
+**Property:** `parquet.compression.codec.zstd.level`
+**Description:** The compression level of ZSTD. The valid range is 1~22.
Generally the higher compression level, the higher compression ratio can be
achieved, but the writing time will be longer.
Review comment:
I was trying to say that _Property_, _Description_ and _Default value_
should be separate paragraphs. Currently they are not, the _Description_ is
rendered just after _Property_ in the same line even if in the markdown they
are separated. You should use one of the techniques described under the link to
force the new line there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace Hadoop ZSTD with JNI-ZSTD
> ---------------------------------
>
> Key: PARQUET-1866
> URL: https://issues.apache.org/jira/browse/PARQUET-1866
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Affects Versions: 1.12.0
> Reporter: Xinli Shang
> Assignee: Xinli Shang
> Priority: Major
> Fix For: 1.12.0
>
>
> The parquet-mr repo has been using
> [ZSTD-JNI|https://github.com/luben/zstd-jni/tree/master/src/main/java/com/github/luben/zstd]
> for the parquet-cli project. It is a cleaner approach to use this JNI than
> using Hadoop ZSTD compression, because 1) on the developing box, installing
> Hadoop is cumbersome, 2) Older version of Hadoop doesn't support ZSTD.
> Upgrading Hadoop is another pain. This Jira is to replace Hadoop ZSTD with
> ZSTD-JNI for parquet-hadoop project.
> According to the author of ZSTD-JNI, Flink, Spark, Cassandra all use ZSTD-JNI
> for ZSTD.
> Another approach is to use https://github.com/airlift/aircompressor which is
> a pure Java implementation. But it seems the compression level is not
> adjustable in aircompressor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
