[
https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135073#comment-17135073
]
ASF GitHub Bot commented on PARQUET-1373:
-----------------------------------------
ggershinsky commented on a change in pull request #615:
URL: https://github.com/apache/parquet-mr/pull/615#discussion_r439801999
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/samples/VaultClient.java
##########
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.crypto.keytools.samples;
+
+import okhttp3.MediaType;
+import okhttp3.OkHttpClient;
+import okhttp3.Request;
+import okhttp3.RequestBody;
+import okhttp3.Response;
+
+import org.apache.parquet.crypto.KeyAccessDeniedException;
+import org.apache.parquet.crypto.ParquetCryptoRuntimeException;
+import org.apache.parquet.crypto.keytools.KmsClient;
+import org.apache.parquet.crypto.keytools.RemoteKmsClient;
+import org.codehaus.jackson.map.ObjectMapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Base64;
+import java.util.HashMap;
+import java.util.Map;
+
+public class VaultClient extends RemoteKmsClient {
Review comment:
re samples - we have two classes there, `InMemoryKMS` and `VaultClient`.
`InMemoryKMS` is leveraged in the unitest for the Key Tools feature.
So indeed it should make sense to move it to the tests.
As for the `VaultClient` - one option is to move it also to the tests
location, commenting out the HTTP calls so the `okhttp3` dependency can be
removed from the pom. The comments will explain the code and how to build it if
needed. The other option is to remove `VaultClient` altogether from
apache/parquet-mr (I can keep it eg in my fork, as a pointer if anybody's
interested to see a sample). What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Encryption key management tools
> --------------------------------
>
> Key: PARQUET-1373
> URL: https://issues.apache.org/jira/browse/PARQUET-1373
> Project: Parquet
> Issue Type: New Feature
> Components: parquet-mr
> Reporter: Gidon Gershinsky
> Assignee: Gidon Gershinsky
> Priority: Major
>
> Parquet Modular Encryption
> ([PARQUET-1178|https://issues.apache.org/jira/browse/PARQUET-1178]) provides
> an API that accepts keys, arbitrary key metadata and key retrieval callbacks
> - which allows to implement basically any key management policy on top of it.
> This Jira will add tools that implement a set of best practice elements for
> key management. This is not an end-to-end key management, but rather a set of
> components that might simplify design and development of an end-to-end
> solution.
> This tool set is one of many possible. There is no goal to create a single or
> “standard” toolkit for Parquet encryption keys. Parquet has a Crypto Factory
> interface [(PARQUET-1817|https://issues.apache.org/jira/browse/PARQUET-1817])
> that allows to plug in different implementations of encryption key management.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
