ggershinsky commented on a change in pull request #615:
URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447509073
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/PropertiesDrivenCryptoFactory.java
##########
@@ -36,38 +39,62 @@
import org.apache.parquet.crypto.ParquetCryptoRuntimeException;
import org.apache.parquet.hadoop.api.WriteSupport.WriteContext;
import org.apache.parquet.hadoop.metadata.ColumnPath;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import static org.apache.parquet.crypto.keytools.KeyToolkit.stringIsEmpty;
public class PropertiesDrivenCryptoFactory implements
EncryptionPropertiesFactory, DecryptionPropertiesFactory {
-
- public static final String COLUMN_KEYS_PROPERTY_NAME =
"encryption.column.keys";
- public static final String FOOTER_KEY_PROPERTY_NAME =
"encryption.footer.key";
- public static final String ENCRYPTION_ALGORITHM_PROPERTY_NAME =
"encryption.algorithm";
- public static final String PLAINTEXT_FOOTER_PROPERTY_NAME =
"encryption.plaintext.footer";
+ private static final Logger LOG =
LoggerFactory.getLogger(PropertiesDrivenCryptoFactory.class);
- public static final int DEK_LENGTH = 16;
-
- private static final SecureRandom random = new SecureRandom();
+ private static final Integer[] ACCEPTABLE_DATA_KEY_LENGTHS = {128, 192, 256};
+ private static final Set<Integer> ACCEPTABLE_DATA_KEY_LENGTHS_SET =
+ new HashSet<>(Arrays.asList(ACCEPTABLE_DATA_KEY_LENGTHS));
Review comment:
Sure, we'll change this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
