[
https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269235#comment-17269235
]
ASF GitHub Bot commented on PARQUET-1926:
-----------------------------------------
gszadovszky commented on a change in pull request #832:
URL: https://github.com/apache/parquet-mr/pull/832#discussion_r561796333
##########
File path:
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
##########
@@ -325,7 +323,7 @@ private ConvertedField visitPrimitiveType(PrimitiveTypeName
type, LogicalTypeAnn
@Override
public ConvertedField visit(EnumType enumType, State state) {
- return visitPrimitiveType(BINARY, enumType(), state);
+ return visitPrimitiveType(BINARY, LogicalTypeAnnotation.enumType(), state);
Review comment:
Why you don't like static imports? This change (and the removing of the
related import) seems to be useless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add LogicalType support to ThriftType.I64Type
> ---------------------------------------------
>
> Key: PARQUET-1926
> URL: https://issues.apache.org/jira/browse/PARQUET-1926
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-thrift
> Reporter: Joshua Martone
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Adds a LogicalTypeAnnotation to the I64Type.
> This allows you to serialize timestamps and times.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
