[
https://issues.apache.org/jira/browse/PARQUET-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281973#comment-17281973
]
ASF GitHub Bot commented on PARQUET-1970:
-----------------------------------------
shangxinli commented on a change in pull request #861:
URL: https://github.com/apache/parquet-mr/pull/861#discussion_r573157999
##########
File path: parquet-common/src/main/java/org/apache/parquet/io/OutputFile.java
##########
@@ -31,5 +31,7 @@
long defaultBlockSize();
- String getPath();
+ default String getPath() {
+ throw new UnsupportedOperationException();
Review comment:
+1 for using null instead of through exception, which is expensive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make minor releases source compatible
> -------------------------------------
>
> Key: PARQUET-1970
> URL: https://issues.apache.org/jira/browse/PARQUET-1970
> Project: Parquet
> Issue Type: Bug
> Affects Versions: 1.12.0
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
>
> Currently the compatibility checker ({{japicmp-maven-plugin}}) is configured
> to allow source incompatible changes for minor releases. It does not seem to
> be a great burden not allow such changes.
> Meanwhile a potential [bug|https://github.com/siom79/japicmp/issues/281] is
> discovered in the tool. Let's wait for this issue to be clarified because if
> it is not a bug then changes in parquet-mr will be required.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
