[
https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294676#comment-17294676
]
Maya Anderson commented on PARQUET-1992:
----------------------------------------
[~gszadovszky] , I would say that there are 2 questions here:
1. Should the interop tests run separately from unit tests?
* Benefit - the regular dev flow of building and running unit tests won't
require downloading files and connectivity to github
* If so, they could be run by {{maven-failsafe-plugin}} as part of the
integration-test/verify phase and missing the interop files would not fail
"{{mvn install}}" but only "{{mvn verify}}"
2. Should the files for interop tests be downloaded directly in the test or
using submodules in a separate maven profile for integration-test or as part of
an existing profile, e.g. {{ci-test}}?
I see the following advantages of the submodule approach:
* Git submodules provides flows for handling downloaded file versions -
specific to a commit or a branch.
* Git submodules manages downloading files only when needed
* It is aligned with the integration tests in parquet-cpp (arrow)
* The files can be used for additional interop tests of other features
Disadvantages:
* The tarball still won't contain the interop files, so the integration tests
will fail on it. However, if interop tests are separate from unit tests, then
maybe it shouldn't be a problem?
Anyway, both ways are acceptable, so I'll implement whatever sounds best to the
community.
BTW, when investigating the profiles, it seems to me that there is an old
reference to the "travis" maven profile mentioned in the .travis.yml file,
though its new name is "ci-test".
> Cannot build from tarball because of git submodules
> ---------------------------------------------------
>
> Key: PARQUET-1992
> URL: https://issues.apache.org/jira/browse/PARQUET-1992
> Project: Parquet
> Issue Type: Bug
> Reporter: Gabor Szadovszky
> Priority: Blocker
>
> Because we use git submodules (to get test parquet files) a simple "mvn clean
> install" fails from the unpacked tarball due to "not a git repository".
> I think we would have 2 options to solve this situation:
> * Include all the required files (even only for testing) in the tarball and
> somehow avoid the git submodule update in case of executed in a non-git
> envrionment
> * Make the downloading of the parquet files and the related tests optional so
> it won't fail the build from the tarball
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
