dossett commented on a change in pull request #886: URL: https://github.com/apache/parquet-mr/pull/886#discussion_r604951366
########## File path: parquet-protobuf/src/test/java/org/apache/parquet/proto/TestUtils.java ########## @@ -198,14 +197,11 @@ private static void checkSameBuilderInstance(MessageOrBuilder[] messages) { * Writes messages to temporary file and returns its path. */ public static Path writeMessages(MessageOrBuilder... records) throws IOException { - return writeMessages(inferRecordsClass(records), records); - } - - public static Path writeMessages(Class<? extends Message> cls, MessageOrBuilder... records) throws IOException { Path file = someTemporaryFilePath(); + Class<? extends Message> cls = inferRecordsClass(records); - ProtoParquetWriter<MessageOrBuilder> writer = - new ProtoParquetWriter<MessageOrBuilder>(file, cls); + ParquetWriter<MessageOrBuilder> writer = + ProtoParquetWriter.<MessageOrBuilder>builder(file).withMessage(cls).build(); Review comment: This change just switches the only internal use of the deprecated constructors to use the `builder` pattern, and does some other minor cleanup with these methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org