[
https://issues.apache.org/jira/browse/PARQUET-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314575#comment-17314575
]
ASF GitHub Bot commented on PARQUET-2013:
-----------------------------------------
pitrou commented on a change in pull request #169:
URL: https://github.com/apache/parquet-format/pull/169#discussion_r606833694
##########
File path: src/main/thrift/parquet.thrift
##########
@@ -316,7 +317,7 @@ struct BsonType {
* LogicalType annotations to replace ConvertedType.
*
* To maintain compatibility, implementations using LogicalType for a
- * SchemaElement must also set the corresponding ConvertedType from the
+ * SchemaElement should also set the corresponding ConvertedType from the
Review comment:
Well, given the state, even today, of inter-implementation
compatibility, I think anyone using a 2017-era implementation would run into
lots of issues when reading files produced by other implementations, regardless
of whether logical types are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Format] Mention that converted types are deprecated
> ----------------------------------------------------
>
> Key: PARQUET-2013
> URL: https://issues.apache.org/jira/browse/PARQUET-2013
> Project: Parquet
> Issue Type: Task
> Components: parquet-format
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Major
> Fix For: format-2.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
