pitrou commented on a change in pull request #169: URL: https://github.com/apache/parquet-format/pull/169#discussion_r606835027
########## File path: src/main/thrift/parquet.thrift ########## @@ -316,7 +317,7 @@ struct BsonType { * LogicalType annotations to replace ConvertedType. * * To maintain compatibility, implementations using LogicalType for a - * SchemaElement must also set the corresponding ConvertedType from the + * SchemaElement should also set the corresponding ConvertedType from the Review comment: That said, if people feel strongly about it, I can simply revert this one-word change, because I don't think there's any point organizing a vote on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org