wesm commented on a change in pull request #169:
URL: https://github.com/apache/parquet-format/pull/169#discussion_r606832265
##########
File path: src/main/thrift/parquet.thrift
##########
@@ -316,7 +317,7 @@ struct BsonType {
* LogicalType annotations to replace ConvertedType.
*
* To maintain compatibility, implementations using LogicalType for a
- * SchemaElement must also set the corresponding ConvertedType from the
+ * SchemaElement should also set the corresponding ConvertedType from the
Review comment:
If you want to make this change, I think it needs to be voted on.
Knowing the motley state of Parquet implementations in enterprise deployments I
would be uncomfortable writing files that don't have the field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
