gszadovszky commented on a change in pull request #896:
URL: https://github.com/apache/parquet-mr/pull/896#discussion_r618574258
##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/Offsets.java
##########
@@ -68,12 +68,14 @@ public static Offsets getOffsets(SeekableInputStream input,
ColumnChunkMetaData
return new Offsets(firstDataPageOffset, dictionaryPageOffset);
}
- private static long readDictionaryPageSize(SeekableInputStream in, long pos)
throws IOException {
+ private static long readDictionaryPageSize(SeekableInputStream in,
ColumnChunkMetaData chunk) throws IOException {
long origPos = -1;
try {
origPos = in.getPos();
+ in.seek(chunk.getStartingPos());
Review comment:
I agree it should be specified more clearly and maybe not only in the
Encoding doc but somewhere in the "main" page but I feel it a separate topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
