[ https://issues.apache.org/jira/browse/PARQUET-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405496#comment-17405496 ]
ASF GitHub Bot commented on PARQUET-1968: ----------------------------------------- dbtsai commented on a change in pull request #923: URL: https://github.com/apache/parquet-mr/pull/923#discussion_r697021579 ########## File path: parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java ########## @@ -287,6 +291,27 @@ boolean isNullPage(int pageIndex) { pageIndex -> nullCounts[pageIndex] > 0 || matchingIndexes.contains(pageIndex)); } + @Override Review comment: +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > FilterApi support In predicate > ------------------------------ > > Key: PARQUET-1968 > URL: https://issues.apache.org/jira/browse/PARQUET-1968 > Project: Parquet > Issue Type: Improvement > Components: parquet-mr > Affects Versions: 1.12.0 > Reporter: Yuming Wang > Priority: Major > > FilterApi should support native In predicate. > Spark: > https://github.com/apache/spark/blob/d6a68e0b67ff7de58073c176dd097070e88ac831/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala#L600-L605 > Impala: > https://issues.apache.org/jira/browse/IMPALA-3654 -- This message was sent by Atlassian Jira (v8.3.4#803005)