shangxinli commented on code in PR #988: URL: https://github.com/apache/parquet-mr/pull/988#discussion_r950888122
########## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java: ########## @@ -79,12 +80,20 @@ public MessageType convert(Class<? extends Message> protobufClass) { } /* Iterates over list of fields. **/ - private <T> GroupBuilder<T> convertFields(GroupBuilder<T> groupBuilder, List<FieldDescriptor> fieldDescriptors) { + private <T> GroupBuilder<T> convertFields(GroupBuilder<T> groupBuilder, List<FieldDescriptor> fieldDescriptors, List<String> parentNames) { for (FieldDescriptor fieldDescriptor : fieldDescriptors) { - groupBuilder = - addField(fieldDescriptor, groupBuilder) + final String name = fieldDescriptor.getFullName(); + final List<String> newParentNames = new ArrayList<>(parentNames); + newParentNames.add(name); + if (parentNames.contains(name)) { + // Circular dependency, skip + LOG.warn("Breaking circular dependency:{}{}", System.lineSeparator(), Review Comment: I am not very familiar with Proto. By design, is the 'circular' normal in the proto or it is caused by issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org