yabola commented on code in PR #1020:
URL: https://github.com/apache/parquet-mr/pull/1020#discussion_r1070636680
##########
parquet-column/src/main/java/org/apache/parquet/column/values/bloomfilter/BlockSplitBloomFilter.java:
##########
@@ -398,18 +398,21 @@ public long hash(Binary value) {
@Override
public void merge(BloomFilter otherBloomFilter) throws IOException {
- Preconditions.checkArgument((otherBloomFilter.getAlgorithm() ==
getAlgorithm()),
- "BloomFilter algorithm should be same");
- Preconditions.checkArgument((otherBloomFilter.getHashStrategy() ==
getHashStrategy()),
- "BloomFilter hashStrategy should be same");
- Preconditions.checkArgument((otherBloomFilter.getBitsetSize() ==
getBitsetSize()),
- "BloomFilter bitset size should be same");
+ Preconditions.checkArgument(otherBloomFilter != null, "Cannot merge a null
BloomFilter");
+ Preconditions.checkArgument((getAlgorithm() ==
otherBloomFilter.getAlgorithm()),
Review Comment:
Thanks, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
