[ https://issues.apache.org/jira/browse/PARQUET-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715151#comment-17715151 ]
ASF GitHub Bot commented on PARQUET-2292: ----------------------------------------- clairemcginty opened a new pull request, #1078: URL: https://github.com/apache/parquet-mr/pull/1078 Context: AvroWriteSupport/AvroReadSupport can improve the precision of their default `model` selection. Currently they default to new SpecificDataSupplier().get()[0]. This means that SpecificRecord classes that contain logical types will fail out-of-the-box unless a specific DATA_SUPPLIER is configured that contains logical type conversions. This PR attempts to derive a `model` by reflecting the `MODEL$` field from the SpecificRecordBase implementation, which in Avro 1.11 comes pre-loaded with all necessary logical type conversions for that Specific Avro class. (For Avro 1.8 compatibility, we have to add the conversions manually from the `conversions` field.) ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-XXX - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does > Improve default SpecificRecord model selection for Avro{Write,Read}Support > -------------------------------------------------------------------------- > > Key: PARQUET-2292 > URL: https://issues.apache.org/jira/browse/PARQUET-2292 > Project: Parquet > Issue Type: Improvement > Reporter: Claire McGinty > Priority: Major > > AvroWriteSupport/AvroReadSupport can improve the precision of their default > `model` selection. Currently they default to new > SpecificDataSupplier().get()[0]. This means that SpecificRecord classes that > contain logical types will fail out-of-the-box unless a specific > DATA_SUPPLIER is configured that contains logical type conversions. > I think we can improve this and make logical types work by default by > defaulting to the value of the `MODEL$` field that every SpecificRecordBase > implementation contains, which already contains all the logical conversions > for that Avro type. It would require reflection, but that's what the Avro > library is already doing to fetch models for Specific types[1]. > > [0] > [https://github.com/apache/parquet-mr/blob/d38044f5395494e1543581a4b763f624305d3022/parquet-avro/src/main/java/org/apache/parquet/avro/AvroWriteSupport.java#L403-L407] > [1] > https://github.com/apache/avro/blob/release-1.11.1/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java#L76-L86 -- This message was sent by Atlassian Jira (v8.20.10#820010)