clairemcginty commented on code in PR #1078: URL: https://github.com/apache/parquet-mr/pull/1078#discussion_r1182865579
########## parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java: ########## @@ -169,6 +172,46 @@ public void add(Object value) { } } + /** + * Returns the specific data model for a given SpecificRecord schema by reflecting the underlying + * Avro class's `MODEL$` field, or Null if the class is not on the classpath or reflection fails. + */ + static SpecificData getModelForSchema(Schema schema) { + final Class<?> clazz; + + if (schema != null && (schema.getType() == Schema.Type.RECORD || schema.getType() == Schema.Type.UNION)) { + clazz = SpecificData.get().getClass(schema); + } else { + return null; + } + + final SpecificData model; + try { + final Field modelField = clazz.getDeclaredField("MODEL$"); + modelField.setAccessible(true); + + model = (SpecificData) modelField.get(null); + } catch (Exception e) { + return null; + } + + try { + final String avroVersion = Schema.Parser.class.getPackage().getImplementationVersion(); + // Avro 1.8 doesn't include conversions in the MODEL$ field + if (avroVersion.startsWith("1.8.")) { Review Comment: ok, I've added a new test suite, `TestAvroRecordConverter`, that thoroughly tests `getModelForSchema` with a variety of schema variants and with Avro versions 1.{7,8,9,10,11}. To do this, I used Powermock to mock the static invocation used to get Avro runtime version, then I ad-hoc compiled Avro generated classes using compiler versions 1.{7,8,9,10,11}. Happy to take a different approach with testing if you prefer -- this just seemed like the most straightforward way to do it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org