rdblue commented on code in PR #1084:
URL: https://github.com/apache/parquet-mr/pull/1084#discussion_r1182872918
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java:
##########
@@ -37,6 +41,39 @@ public class HadoopStreams {
private static final Logger LOG =
LoggerFactory.getLogger(HadoopStreams.class);
+ private static final Class<?> byteBufferReadableClass = getReadableClass();
+ static final Constructor<SeekableInputStream> h2SeekableConstructor =
getH2SeekableConstructor();
Review Comment:
Looks like you'd need to add the `orNull` handling. I don't see it here:
https://github.com/apache/parquet-mr/blob/master/parquet-common/src/main/java/org/apache/parquet/util/DynConstructors.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
