[ 
https://issues.apache.org/jira/browse/PARQUET-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730185#comment-17730185
 ] 

ASF GitHub Bot commented on PARQUET-2305:
-----------------------------------------

tddfan commented on code in PR #1102:
URL: https://github.com/apache/parquet-mr/pull/1102#discussion_r1221866081


##########
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoMessageConverter.java:
##########
@@ -31,9 +29,7 @@
 import org.apache.parquet.io.api.Converter;
 import org.apache.parquet.io.api.GroupConverter;
 import org.apache.parquet.io.api.PrimitiveConverter;
-import org.apache.parquet.schema.GroupType;
-import org.apache.parquet.schema.IncompatibleSchemaModificationException;
-import org.apache.parquet.schema.LogicalTypeAnnotation;
+import org.apache.parquet.schema.*;

Review Comment:
   Resolved.





> Allow Parquet to Proto conversion even though Target Schema has less fields
> ---------------------------------------------------------------------------
>
>                 Key: PARQUET-2305
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2305
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-protobuf
>            Reporter: Sanjay Sharma
>            Priority: Major
>
> If Parquet has any field which has been removed from the schema and Parquet 
> to Proto conversion happens, it errors out due to Unknown fields. There could 
> be some scenarios that we want to still convert PARQUET into the target proto 
> schema object which has lesser fields.
> If specified "ignoreUnknownFields" as an argument, this should allow the 
> conversion which ignore fields it can't convert and not error out.
> Similar functionality exist in 
> [https://github.com/protocolbuffers/protobuf/blob/main/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java]
>  with field "ignoringUnknownFields"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to