mapleFU commented on code in PR #197: URL: https://github.com/apache/parquet-format/pull/197#discussion_r1302011495
########## src/main/thrift/parquet.thrift: ########## @@ -974,6 +1050,13 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5: optional list<i64> null_counts + /** + * Repetition and definition level histograms for the pages. + * + * This contains some redundancy with null_counts, however, to accommodate the + * widest range of readers both should be populated. + **/ + 6: optional list<RepetitionDefinitionLevelHistogram> repetition_definition_level_histograms; Review Comment: I think `SizeEstimationStatistics` is already in `ColumnChunk`, would a page level `unencoded_variable_width_stored_bytes` helps pruning? Since here the `repetition_definition_level_histograms` can help pruning like `struct.list_child == null`? If we want this it's even more better to put `unencoded_variable_width_stored_bytes` into `OffsetIndex`. It's much more like `compressed_page_size` there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org