etseidl commented on code in PR #197:
URL: https://github.com/apache/parquet-format/pull/197#discussion_r1318190332
##########
src/main/thrift/parquet.thrift:
##########
@@ -977,6 +1073,15 @@ struct ColumnIndex {
/** A list containing the number of null values for each page **/
5: optional list<i64> null_counts
+ /**
+ * Repetition and definition level histograms for the pages.
+ *
+ * This contains some redundancy with null_counts, however, to accommodate
+ * the widest range of readers both should be populated when either the max
+ * definition and repetition level meet the requirements specified in
+ * RepetitionDefinitionLevelHistogram.
+ **/
+ 6: optional list<RepetitionDefinitionLevelHistogram>
repetition_definition_level_histograms
Review Comment:
> I'm actually somewhat inclined to take this approach if others are OK with
it.
Fine with me. As long as the data is present I don't really care about the
form. And given the fact the I have to hand code the thrift encoding, I
appreciate the lesser complexity of encoding a single array per histogram.
As to organization of histograms, it would be more efficient in my case to
encode a page at a time rather than a level at a time since that's how I have
the histograms organized in memory.
Will `SizeStatistics` still be used at the chunk level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
