[ https://issues.apache.org/jira/browse/PARQUET-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775714#comment-17775714 ]
ASF GitHub Bot commented on PARQUET-2351: ----------------------------------------- amousavigourabi commented on code in PR #1157: URL: https://github.com/apache/parquet-mr/pull/1157#discussion_r1360519336 ########## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java: ########## @@ -341,7 +341,7 @@ public static void setMaxPaddingSize(Configuration conf, int maxPaddingSize) { conf.setInt(MAX_PADDING_BYTES, maxPaddingSize); } - private static int getMaxPaddingSize(Configuration conf) { + public static int getMaxPaddingSize(Configuration conf) { Review Comment: 👍 I'll add it for the rest of the publics in the class as well while I'm at it. ########## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java: ########## @@ -341,7 +341,7 @@ public static void setMaxPaddingSize(Configuration conf, int maxPaddingSize) { conf.setInt(MAX_PADDING_BYTES, maxPaddingSize); } - private static int getMaxPaddingSize(Configuration conf) { + public static int getMaxPaddingSize(Configuration conf) { Review Comment: 👍 I'll add it for the rest of the publics in the class as well while I'm at it. > ParquetWriter/ParquetReader should parse options directly from supplied > Configuration > ------------------------------------------------------------------------------------- > > Key: PARQUET-2351 > URL: https://issues.apache.org/jira/browse/PARQUET-2351 > Project: Parquet > Issue Type: Improvement > Reporter: Claire McGinty > Priority: Minor > > As a Parquet user, my expectation is that ParquetWriter/ParquetReader will > automatically parse any options passed in the supplied Configuration. For > example: > > ``` > Configuration conf = new Configuration(); > conf.setBoolean(ParquetOutputFormat.BLOOM_FILTER_ENABLED, true); > ParquetWriter<Car> writer = AvroParquetWriter.<Car>builder(path) > .withSchema(Car.SCHEMA$) > .withConf(conf) > .build(); > ``` > > However, the above code results in a ParquetWriter where `bloomFilterEnabled` > is set to false-the expected way to configure this is to use > `ParquetWriter#withBloomFilterEnabled` directly. > > IMO, when `ParquetWriter#withConf` is invoked, it should also delegate to > `encodingPropsBuilder` and set any Configured properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)