[
https://issues.apache.org/jira/browse/PARQUET-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777531#comment-17777531
]
ASF GitHub Bot commented on PARQUET-2355:
-----------------------------------------
wgtmac commented on code in PR #1175:
URL: https://github.com/apache/parquet-mr/pull/1175#discussion_r1366355044
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/DeprecatedFieldProjectionFilter.java:
##########
@@ -1,106 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.parquet.thrift.projection.deprecated;
-
-import java.util.LinkedList;
-import java.util.List;
-import java.util.Objects;
-
-import org.apache.parquet.thrift.projection.FieldsPath;
-import org.apache.parquet.thrift.projection.FieldProjectionFilter;
-import org.apache.parquet.thrift.projection.ThriftProjectionException;
-
-/**
- * Filter thrift attributes using glob syntax.
- * This is used for parsing values assigned to
ThriftReadSupport.THRIFT_COLUMN_FILTER_KEY
- */
-@Deprecated
-public class DeprecatedFieldProjectionFilter implements FieldProjectionFilter {
Review Comment:
Why is this file removed?
##########
parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftReadSupport.java:
##########
@@ -41,21 +41,13 @@
import org.apache.parquet.thrift.projection.FieldProjectionFilter;
import org.apache.parquet.thrift.projection.StrictFieldProjectionFilter;
import org.apache.parquet.thrift.projection.ThriftProjectionException;
-import
org.apache.parquet.thrift.projection.deprecated.DeprecatedFieldProjectionFilter;
import org.apache.parquet.thrift.struct.ThriftType.StructType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+@Deprecated
public class ThriftReadSupport<T> extends ReadSupport<T> {
private static final Logger LOG =
LoggerFactory.getLogger(ThriftReadSupport.class);
-
- /**
- * Deprecated. Use {@link #STRICT_THRIFT_COLUMN_FILTER_KEY}
- * Accepts a ";" delimited list of globs in the syntax implemented by {@link
DeprecatedFieldProjectionFilter}
- */
- @Deprecated
Review Comment:
Why not keeping them as-is?
> Deprecate parquet-thrift
> ------------------------
>
> Key: PARQUET-2355
> URL: https://issues.apache.org/jira/browse/PARQUET-2355
> Project: Parquet
> Issue Type: Improvement
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
>
> I was in the process of updating to [the latest version of
> Thrift|https://github.com/apache/parquet-mr/pull/1138] (from 0.16.0 to
> 0.19.0). Mostly because it contains CVEs and makes the release process easier
> because you don't have to install Thrift from source (it is just available on
> homebrew etc).
>
> While working on this, I ran into an issue with Elephantbird, which is using
> a very old version of Thrift (0.7.0). Trying to bump this I noticed that a
> lot of classes that we use in the tests
> [have|https://github.com/apache/parquet-mr/pull/1156] [ been made
> private|https://github.com/apache/parquet-mr/pull/1156]. Therefore it is hard
> to test if we break anything.
>
> It looks like parquet-thrift [is not used by anyone
> anymore|https://mvnrepository.com/artifact/org.apache.parquet/parquet-thrift].
> I would suggest removing this from the repository unless anyone objects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
