[
https://issues.apache.org/jira/browse/PARQUET-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776689#comment-17776689
]
ASF GitHub Bot commented on PARQUET-2355:
-----------------------------------------
Fokko opened a new pull request, #1175:
URL: https://github.com/apache/parquet-mr/pull/1175
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2355
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Deprecate parquet-thrift
> ------------------------
>
> Key: PARQUET-2355
> URL: https://issues.apache.org/jira/browse/PARQUET-2355
> Project: Parquet
> Issue Type: Improvement
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
>
> I was in the process of updating to [the latest version of
> Thrift|https://github.com/apache/parquet-mr/pull/1138] (from 0.16.0 to
> 0.19.0). Mostly because it contains CVEs and makes the release process easier
> because you don't have to install Thrift from source (it is just available on
> homebrew etc).
>
> While working on this, I ran into an issue with Elephantbird, which is using
> a very old version of Thrift (0.7.0). Trying to bump this I noticed that a
> lot of classes that we use in the tests
> [have|https://github.com/apache/parquet-mr/pull/1156] [ been made
> private|https://github.com/apache/parquet-mr/pull/1156]. Therefore it is hard
> to test if we break anything.
>
> It looks like parquet-thrift [is not used by anyone
> anymore|https://mvnrepository.com/artifact/org.apache.parquet/parquet-thrift].
> I would suggest removing this from the repository unless anyone objects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
