Fokko commented on code in PR #1175:
URL: https://github.com/apache/parquet-mr/pull/1175#discussion_r1366717276
##########
parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftReadSupport.java:
##########
@@ -41,21 +41,13 @@
import org.apache.parquet.thrift.projection.FieldProjectionFilter;
import org.apache.parquet.thrift.projection.StrictFieldProjectionFilter;
import org.apache.parquet.thrift.projection.ThriftProjectionException;
-import
org.apache.parquet.thrift.projection.deprecated.DeprecatedFieldProjectionFilter;
import org.apache.parquet.thrift.struct.ThriftType.StructType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+@Deprecated
public class ThriftReadSupport<T> extends ReadSupport<T> {
private static final Logger LOG =
LoggerFactory.getLogger(ThriftReadSupport.class);
-
- /**
- * Deprecated. Use {@link #STRICT_THRIFT_COLUMN_FILTER_KEY}
- * Accepts a ";" delimited list of globs in the syntax implemented by {@link
DeprecatedFieldProjectionFilter}
- */
- @Deprecated
Review Comment:
These are marked as deprecated in 2015. I think removing these is a first
step before removing the whole class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
