wgtmac commented on code in PR #1181:
URL: https://github.com/apache/parquet-mr/pull/1181#discussion_r1378884953
##########
pom.xml:
##########
@@ -546,6 +546,13 @@
<!-- japicmp is overly aggressive on interface types in
signatures, a type was changed to a supertype but this still triggers it -->
<exclude>org.apache.parquet.hadoop.ColumnChunkPageWriteStore</exclude>
<exclude>org.apache.parquet.hadoop.ParquetRecordWriter</exclude>
+ <!-- likely japicmp bug, triggers on new interface methods after
updating to 0.18.1 -->
+
<exclude>org.apache.parquet.conf.ParquetConfiguration#getClass(java.lang.String,java.lang.Class,java.lang.Class)</exclude>
+
<exclude>org.apache.parquet.hadoop.util.SerializationUtil#readObjectFromConfAsBase64(java.lang.String,org.apache.parquet.conf.ParquetConfiguration)</exclude>
+
<exclude>org.apache.parquet.conf.HadoopParquetConfiguration#getClass(java.lang.String,java.lang.Class,java.lang.Class)</exclude>
+
<exclude>org.apache.parquet.avro.AvroParquetReader#builder(org.apache.parquet.io.InputFile,org.apache.parquet.conf.ParquetConfiguration)</exclude>
+
<exclude>org.apache.parquet.util.Reflection#newInstance(java.lang.Class)</exclude>
Review Comment:
This class is removed in this PR. Should this line be deleted as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
