wgtmac commented on code in PR #1173:
URL: https://github.com/apache/parquet-mr/pull/1173#discussion_r1381201667
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1317,6 +1324,27 @@ private int toIntWithCheck(long size) {
return (int)size;
}
+ private void mergeColumnStatistics(Statistics<?> statistics) {
+ if (!currentStatisticsAreValid) {
Review Comment:
Are we able to reuse `currentStatistics.isEmpty()` in this case? We can
simply set currentStatistics to empty if any unexpected statistics are to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
